Re: [PATCH v2 3/4] progress: clear previous progress update dynamically

2019-04-02 Thread Jeff King
On Mon, Apr 01, 2019 at 04:15:42PM +0200, SZEDER Gábor wrote: > > I don't think it could matter here, as these are meant to be smallish > > strings, but I think we should get into the habit of using size_t > > consistently to hold string lengths. > > > > It makes auditing for integer overflow pro

Re: [PATCH v2 3/4] progress: clear previous progress update dynamically

2019-04-01 Thread SZEDER Gábor
On Mon, Apr 01, 2019 at 09:30:00AM -0400, Jeff King wrote: > On Mon, Apr 01, 2019 at 01:52:16PM +0200, SZEDER Gábor wrote: > > > diff --git a/progress.c b/progress.c > > index 842db14b72..3149ecd460 100644 > > --- a/progress.c > > +++ b/progress.c > > @@ -84,6 +84,7 @@ static void display(struct p

Re: [PATCH v2 3/4] progress: clear previous progress update dynamically

2019-04-01 Thread Jeff King
On Mon, Apr 01, 2019 at 01:52:16PM +0200, SZEDER Gábor wrote: > diff --git a/progress.c b/progress.c > index 842db14b72..3149ecd460 100644 > --- a/progress.c > +++ b/progress.c > @@ -84,6 +84,7 @@ static void display(struct progress *progress, uint64_t n, > const char *done) > const char *t