Re: [PATCH v2 2/2] send-email: handle adjacent RFC 2047-encoded words properly

2014-12-10 Thread Philip Oakley
From: "Роман Донченко" Sent: Sunday, December 07, 2014 6:17 PM Would that be worth a terse comment in the documentation change part of the patch? "Multiple (RFC2047) encodings are not supported.", or would that be bike shed noise. I didn't change any documentation... and in either case, the

Re: [PATCH v2 2/2] send-email: handle adjacent RFC 2047-encoded words properly

2014-12-07 Thread Роман Донченко
Philip Oakley писал в своём письме Sun, 07 Dec 2014 20:48:05 +0300: From: "Роман Донченко" Jeff King писал в своём письме Sun, 07 Dec 2014 12:18:59 +0300: On Sat, Dec 06, 2014 at 10:36:23PM +0300, Роман Донченко wrote: One final note on this bit of code: if there are multiple encoded

Re: [PATCH v2 2/2] send-email: handle adjacent RFC 2047-encoded words properly

2014-12-07 Thread Philip Oakley
From: "Роман Донченко" Jeff King писал в своём письме Sun, 07 Dec 2014 12:18:59 +0300: On Sat, Dec 06, 2014 at 10:36:23PM +0300, Роман Донченко wrote: The RFC says that they are to be concatenated after decoding (i.e. the intervening whitespace is ignored). Thanks. Both patches look go

Re: [PATCH v2 2/2] send-email: handle adjacent RFC 2047-encoded words properly

2014-12-07 Thread Роман Донченко
Jeff King писал в своём письме Sun, 07 Dec 2014 12:18:59 +0300: On Sat, Dec 06, 2014 at 10:36:23PM +0300, Роман Донченко wrote: The RFC says that they are to be concatenated after decoding (i.e. the intervening whitespace is ignored). Thanks. Both patches look good to me, and I'd be happy

Re: [PATCH v2 2/2] send-email: handle adjacent RFC 2047-encoded words properly

2014-12-07 Thread Jeff King
On Sat, Dec 06, 2014 at 10:36:23PM +0300, Роман Донченко wrote: > The RFC says that they are to be concatenated after decoding (i.e. the > intervening whitespace is ignored). Thanks. Both patches look good to me, and I'd be happy to have them applied as-is. I wrote a few comments below, but in al