Re: [PATCH v2 15/18] test-reach: test commit_contains

2018-07-25 Thread Derrick Stolee
On 7/25/2018 2:08 PM, Junio C Hamano wrote: Jonathan Tan writes: + } else if (!strcmp(av[1], "commit_contains")) { + struct ref_filter filter; + struct contains_cache cache; + init_contains_cache(&cache); + + if (ac > 2 && !strcmp(a

Re: [PATCH v2 15/18] test-reach: test commit_contains

2018-07-25 Thread Junio C Hamano
Jonathan Tan writes: >> +} else if (!strcmp(av[1], "commit_contains")) { >> +struct ref_filter filter; >> +struct contains_cache cache; >> +init_contains_cache(&cache); >> + >> +if (ac > 2 && !strcmp(av[2], "--tag")) >> +filt

Re: [PATCH v2 15/18] test-reach: test commit_contains

2018-07-23 Thread Jonathan Tan
> + } else if (!strcmp(av[1], "commit_contains")) { > + struct ref_filter filter; > + struct contains_cache cache; > + init_contains_cache(&cache); > + > + if (ac > 2 && !strcmp(av[2], "--tag")) > + filter.with_commit_tag_algo