Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

2018-05-07 Thread Elijah Newren
On Mon, May 7, 2018 at 10:50 AM, SZEDER Gábor wrote: >> 2) Your completion commands for branch-diff will only complete one >> revision range, not two. e.g. >> git branch-diff origin/master..my-topic@{2} origin/master..my-top >> won't complete "my-topic" as I'd expect. > > It does complete two

Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

2018-05-07 Thread SZEDER Gábor
> 2) Your completion commands for branch-diff will only complete one > revision range, not two. e.g. > git branch-diff origin/master..my-topic@{2} origin/master..my-top > won't complete "my-topic" as I'd expect. It does complete two revision ranges, but if you want to look at reflogs, then yo

Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

2018-05-07 Thread Elijah Newren
Hi Dscho, On Sat, May 5, 2018 at 1:03 PM, Johannes Schindelin wrote: > Hi Elijah, > > On Fri, 4 May 2018, Elijah Newren wrote: > >> - tbdiff aligned output columns better when there were more than 9 >> patches (I'll comment more on patch 09/18) > > I added a new patch to align the patch numbers

Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

2018-05-06 Thread Johannes Schindelin
Hi Brian, On Sun, 6 May 2018, brian m. carlson wrote: > On Fri, May 04, 2018 at 05:34:27PM +0200, Johannes Schindelin wrote: > > The incredibly useful `git-tbdiff` tool to compare patch series (say, > > to see what changed between two iterations sent to the Git mailing > > list) is slightly less

Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

2018-05-06 Thread brian m. carlson
On Fri, May 04, 2018 at 05:34:27PM +0200, Johannes Schindelin wrote: > The incredibly useful `git-tbdiff` tool to compare patch series (say, to see > what changed between two iterations sent to the Git mailing list) is slightly > less useful for this developer due to the fact that it requires the

Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

2018-05-06 Thread Johannes Schindelin
Hi Junio, On Sun, 6 May 2018, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Johannes Schindelin (17): > > Add a function to solve least-cost assignment problems > > Add a new builtin: branch-diff > > Perhaps retitling these to > > hungarian: a function to solve least-cost

Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

2018-05-05 Thread Junio C Hamano
Johannes Schindelin writes: > Johannes Schindelin (17): > Add a function to solve least-cost assignment problems > Add a new builtin: branch-diff Perhaps retitling these to hungarian: a function to solve least-cost assignment problems branch-diff: a new builtin to compare iterations

Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

2018-05-05 Thread Johannes Schindelin
Hi Elijah, On Fri, 4 May 2018, Elijah Newren wrote: > On Fri, May 4, 2018 at 8:34 AM, Johannes Schindelin > wrote: > > The incredibly useful `git-tbdiff` tool to compare patch series (say, to see > > what changed between two iterations sent to the Git mailing list) is > > slightly > > less usef

Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

2018-05-04 Thread Elijah Newren
Hi, On Fri, May 4, 2018 at 9:21 AM, Elijah Newren wrote: > On Fri, May 4, 2018 at 8:34 AM, Johannes Schindelin > wrote: >> The incredibly useful `git-tbdiff` tool to compare patch series (say, to see >> what changed between two iterations sent to the Git mailing list) is slightly >> less useful

Re: [PATCH v2 00/18] Add `branch-diff`, a `tbdiff` lookalike

2018-05-04 Thread Elijah Newren
On Fri, May 4, 2018 at 8:34 AM, Johannes Schindelin wrote: > The incredibly useful `git-tbdiff` tool to compare patch series (say, to see > what changed between two iterations sent to the Git mailing list) is slightly > less useful for this developer due to the fact that it requires the > `hungar