Re: [PATCH v2 00/13] Base SHA-256 implementation

2018-10-16 Thread brian m. carlson
On Tue, Oct 16, 2018 at 01:01:07PM +0900, Junio C Hamano wrote: > "brian m. carlson" writes: > > > t/t0014-hash.sh | 54 > > create mode 100755 t/t0014-hash.sh > > If I am not mistaken, 0014 is already used by another topic in > flight, and will cause test-lint f

Re: [PATCH v2 00/13] Base SHA-256 implementation

2018-10-16 Thread Duy Nguyen
On Mon, Oct 15, 2018 at 4:21 AM brian m. carlson wrote: > > This series provides an actual SHA-256 implementation and wires it up, > along with some housekeeping patches to make it suitable for testing. > > New in this version is a patch which reverts the change to limit hashcmp > to 20 bytes. I'

Re: [PATCH v2 00/13] Base SHA-256 implementation

2018-10-15 Thread Junio C Hamano
"brian m. carlson" writes: > t/t0014-hash.sh | 54 > create mode 100755 t/t0014-hash.sh If I am not mistaken, 0014 is already used by another topic in flight, and will cause test-lint failure on 'pu'.

Re: [PATCH v2 00/13] Base SHA-256 implementation

2018-10-15 Thread Junio C Hamano
"brian m. carlson" writes: > I realize the increase to GIT_MAX_HEXSZ will result in an increase in > memory usage, but we're going to need to do it at some point, and the > sooner the code is in the codebase, the sooner people can play around > with it and test it. Thanks.