Re: [PATCH v2 0/8] commit-graph: segfault & other fixes for broken graphs

2019-03-15 Thread Ævar Arnfjörð Bjarmason
On Fri, Mar 15 2019, Eric Sunshine wrote: > On Thu, Mar 14, 2019 at 5:47 PM Ævar Arnfjörð Bjarmason > wrote: >> I fixed a test to avoid the pattern a0a630192d >> (t/check-non-portable-shell: detect "FOO=bar shell_func", 2018-07-13) >> tests for. The new pattern is more obvious. >> >> As an asid

Re: [PATCH v2 0/8] commit-graph: segfault & other fixes for broken graphs

2019-03-15 Thread Eric Sunshine
On Thu, Mar 14, 2019 at 5:47 PM Ævar Arnfjörð Bjarmason wrote: > I fixed a test to avoid the pattern a0a630192d > (t/check-non-portable-shell: detect "FOO=bar shell_func", 2018-07-13) > tests for. The new pattern is more obvious. > > As an aside I don't get how that doesn't work as intended from t