Re: [PATCH v2] log -G: Ignore binary files

2018-12-14 Thread Thomas Braun
> Junio C Hamano hat am 29. November 2018 um 08:22 > geschrieben: > > > Junio C Hamano writes: > > >> +test_expect_success 'log -G ignores binary files' ' > >> + git checkout --orphan orphan1 && > >> + printf "a\0a" >data.bin && > >> + git add data.bin && > >> + git commit -m "message" &&

Re: [PATCH v2] log -G: Ignore binary files

2018-12-14 Thread Thomas Braun
> Junio C Hamano hat am 29. November 2018 um 08:10 > geschrieben: > > > Thomas Braun writes: > > > Subject: Re: [PATCH v2] log -G: Ignore binary files > > s/Ig/ig/; (will locally munge--this alone is no reason to reroll). Done. > The code changes looked s

Re: [PATCH v2] log -G: Ignore binary files

2018-12-14 Thread Thomas Braun
> Ævar Arnfjörð Bjarmason hat am 28. November 2018 um 13:54 > geschrieben: > > > > On Wed, Nov 28 2018, Thomas Braun wrote: > > Looks much better this time around. Thanks. > > The -G option of log looks for the differences whose patch text > > contains added/removed lines that match regex.

Re: [PATCH v2] log -G: Ignore binary files

2018-11-28 Thread Junio C Hamano
Junio C Hamano writes: >> +test_expect_success 'log -G ignores binary files' ' >> +git checkout --orphan orphan1 && >> +printf "a\0a" >data.bin && >> +git add data.bin && >> +git commit -m "message" && >> +git log -Ga >result && >> +test_must_be_empty result >> +' > > As t

Re: [PATCH v2] log -G: Ignore binary files

2018-11-28 Thread Junio C Hamano
Thomas Braun writes: > Subject: Re: [PATCH v2] log -G: Ignore binary files s/Ig/ig/; (will locally munge--this alone is no reason to reroll). The code changes looked sensible. > diff --git a/t/t4209-log-pickaxe.sh b/t/t4209-log-pickaxe.sh > index 844df760f7..5c3e2a16b2 100755 > -

Re: [PATCH v2] log -G: Ignore binary files

2018-11-28 Thread Ævar Arnfjörð Bjarmason
On Wed, Nov 28 2018, Thomas Braun wrote: Looks much better this time around. > The -G option of log looks for the differences whose patch text > contains added/removed lines that match regex. > > As the concept of patch text only makes sense for text files, we need to > ignore binary files when