Re: [PATCH v2] git-remote-mediawiki: bugfix for pages w/ >500 revisions

2013-09-24 Thread Matthieu Moy
Benoit Person writes: >> d17cf5f3a32f07bf (tests: Introduce test_seq; 2012-08-03) >> >>> + do >>> + echo "creating revision $i" >> >> Do you want to end this line with '&&'? > The way it's intended is that it's more a debug information to see how > it's going on (creating >50

Re: [PATCH v2] git-remote-mediawiki: bugfix for pages w/ >500 revisions

2013-09-24 Thread Benoit Person
On 23 September 2013 19:58, Matthieu Moy wrote: > I'd rather have the comments say "# API version < X" and "# API version >>= X". Next time the API change, "new" Vs "old" will become meaningless. done, thanks On 23 September 2013 20:26, Jonathan Nieder wrote: > Some distros (e.g., Debian) occas

Re: [PATCH v2] git-remote-mediawiki: bugfix for pages w/ >500 revisions

2013-09-23 Thread Eric Sunshine
On Mon, Sep 23, 2013 at 1:26 PM, Benoit Person wrote: > diff --git a/contrib/mw-to-git/t/t9365-continuing-queries.sh > b/contrib/mw-to-git/t/t9365-continuing-queries.sh > new file mode 100755 > index 000..6fb5df4 > --- /dev/null > +++ b/contrib/mw-to-git/t/t9365-continuing-queries.sh > @@ -0,

Re: [PATCH v2] git-remote-mediawiki: bugfix for pages w/ >500 revisions

2013-09-23 Thread Matthieu Moy
Benoit Person writes: > The latest API renamed and moved the "continuing" information in the > response, necessary to build the next query. The code failed to retrieve > that information but still detected that it was in a "continuing > query". As a result, it launched the same query over and ove