Re: [PATCH v2] commit-graph: remove a duplicate assignment

2019-09-27 Thread Derrick Stolee
On 9/27/2019 8:21 AM, Johannes Schindelin wrote: > Hi, > > > On Thu, 26 Sep 2019, Alex Henrie wrote: > >> Signed-off-by: Alex Henrie > > Hrm, the commit message should reflect Stolee's careful consideration, > no? An empty commit message won't be helpful e.g. when cherry-picking on > top of a

Re: [PATCH v2] commit-graph: remove a duplicate assignment

2019-09-27 Thread Johannes Schindelin
Hi, On Thu, 26 Sep 2019, Alex Henrie wrote: > Signed-off-by: Alex Henrie Hrm, the commit message should reflect Stolee's careful consideration, no? An empty commit message won't be helpful e.g. when cherry-picking on top of a branch that already has your v1. Ciao, Johannes > --- > commit-gr