Miklos Vajna wrote:
> I guess that is a should-not-happen category. parse_args() calls
> setup_revisions(), and that will already die() if the argument is not a
> valid object at all.
Then why do you have an if() guarding the code? In my opinion, you
should have an else-clause that die()s with an
On Thu, Apr 11, 2013 at 03:52:44PM +0530, Ramkumar Ramachandra
wrote:
> > + for (i = 0; i < opts->revs->pending.nr; i++) {
> > + unsigned char sha1[20];
> > + const char *name = opts->revs->pending.objects[i].name;
> > +
> > + if (!get_sha1(name, sh
Miklos Vajna wrote:
> When a single argument was a non-commit, the error message used to be:
>
> fatal: BUG: expected exactly one commit from walk
>
> For multiple arguments, when none of the arguments was a commit, the error
> was:
>
> fatal: empty commit set passed
>
> Finally, w
3 matches
Mail list logo
