Re: [PATCH v2] Makefile: detect compiler and enable more warnings in DEVELOPER=1

2018-03-27 Thread Junio C Hamano
Duy Nguyen writes: On Tue, Mar 27, 2018 at 12:02 AM, Junio C Hamano wrote: >> >> - connect.c -Werror=implicit-fallthough around die_initial_contact(). > > This I did not expect. But I just looked again and I had this option > explicitly turned off in config.mak! gcc-6.4 and gcc-4.9 do not > co

Re: [PATCH v2] Makefile: detect compiler and enable more warnings in DEVELOPER=1

2018-03-27 Thread Duy Nguyen
On Tue, Mar 27, 2018 at 12:02 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> The set of extra warnings we enable when DEVELOPER has to be >> conservative because we can't assume any compiler version the >> developer may use. Detect the compiler version so we know when it's >> safe

Re: [PATCH v2] Makefile: detect compiler and enable more warnings in DEVELOPER=1

2018-03-26 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > The set of extra warnings we enable when DEVELOPER has to be > conservative because we can't assume any compiler version the > developer may use. Detect the compiler version so we know when it's > safe to enable -Wextra and maybe more. This is a good idea in gener

Re: [PATCH v2] Makefile: detect compiler and enable more warnings in DEVELOPER=1

2018-03-24 Thread Eric Sunshine
On Sat, Mar 24, 2018 at 8:53 AM, Nguyễn Thái Ngọc Duy wrote: > The set of extra warnings we enable when DEVELOPER has to be > conservative because we can't assume any compiler version the > developer may use. Detect the compiler version so we know when it's > safe to enable -Wextra and maybe more.