Re: [PATCH v2] If `egrep` is aliased, temporary disable it in bash.completion

2012-12-12 Thread Felipe Contreras
On Thu, Dec 6, 2012 at 12:01 PM, Junio C Hamano wrote: > Adam Tkac writes: > >> On Thu, Nov 29, 2012 at 09:33:53AM -0800, Junio C Hamano wrote: >> ... >>> IOW, something along this line? >> >> This won't work, unfortunately, because shopt settings aren't inherited by >> subshell (and for example

Re: [PATCH v2] If `egrep` is aliased, temporary disable it in bash.completion

2012-12-06 Thread Junio C Hamano
Adam Tkac writes: > On Thu, Nov 29, 2012 at 09:33:53AM -0800, Junio C Hamano wrote: > ... >> IOW, something along this line? > > This won't work, unfortunately, because shopt settings aren't inherited by > subshell (and for example egrep is called in subshell). > > I discussed this issue with col

Re: [PATCH v2] If `egrep` is aliased, temporary disable it in bash.completion

2012-12-06 Thread Adam Tkac
On Thu, Nov 29, 2012 at 09:33:53AM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > > Adam Tkac writes: > > > >> Subject: Re: [PATCH v2] If `egrep` is aliased, temporary disable it in > >> bash.completion > > > > The code does not

Re: [PATCH v2] If `egrep` is aliased, temporary disable it in bash.completion

2012-11-29 Thread Junio C Hamano
Junio C Hamano writes: > Adam Tkac writes: > >> Subject: Re: [PATCH v2] If `egrep` is aliased, temporary disable it in >> bash.completion > > The code does not seem to do anything special if it is not aliased, > though, so "If ..." part does not sound corre

Re: [PATCH v2] If `egrep` is aliased, temporary disable it in bash.completion

2012-11-29 Thread Junio C Hamano
Adam Tkac writes: > Subject: Re: [PATCH v2] If `egrep` is aliased, temporary disable it in > bash.completion The code does not seem to do anything special if it is not aliased, though, so "If ..." part does not sound correct; perhaps you meant "just in case egrep is