Re: [PATCH v11 16/41] refs.c: add transaction.status and track OPEN/CLOSED/ERROR

2014-05-28 Thread Ronnie Sahlberg
On Wed, May 28, 2014 at 11:51 AM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: > >> --- a/refs.c >> +++ b/refs.c > [...] >> @@ -3385,6 +3408,9 @@ int ref_transaction_update(struct ref_transaction >> *transaction, >> { >> struct ref_update *update; >> >> + if (transaction->state != R

Re: [PATCH v11 16/41] refs.c: add transaction.status and track OPEN/CLOSED/ERROR

2014-05-28 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > --- a/refs.c > +++ b/refs.c [...] > @@ -3385,6 +3408,9 @@ int ref_transaction_update(struct ref_transaction > *transaction, > { > struct ref_update *update; > > + if (transaction->state != REF_TRANSACTION_OPEN) > + return -1; I still think this i