> On 06 Oct 2017, at 06:56, Jeff King wrote:
>
> On Fri, Oct 06, 2017 at 01:26:48PM +0900, Junio C Hamano wrote:
>
> ...
>> -- >8 --
>> From: Lars Schneider
>> Date: Thu, 5 Oct 2017 12:44:07 +0200
>> Subject: [PATCH] entry.c: check if file exists after checkout
>>
>> If we are checking out a
On Fri, Oct 6, 2017 at 3:05 PM, Jeff King wrote:
>
>> Because we cannot quite tell between the two cases (one is error--we
>> wrote or we thought we wrote, but we cannot find it, the other is
>> dubious--somebody was racing with us in the filesystem), I think it
>> is reasonable to err on the safe
On Fri, Oct 06, 2017 at 03:03:49PM +0900, Junio C Hamano wrote:
> Jeff King writes:
>
> > I don't know if we wanted to capture any of the reasoning behind using
> > error() here or not. Frankly, I'm not sure how to argue for it
> > succinctly. :) I'm happy with letting it live on in the list arc
Jeff King writes:
> I don't know if we wanted to capture any of the reasoning behind using
> error() here or not. Frankly, I'm not sure how to argue for it
> succinctly. :) I'm happy with letting it live on in the list archive.
Are you talking about the "philosophical" thing?
Because we canno
On Fri, Oct 06, 2017 at 01:26:48PM +0900, Junio C Hamano wrote:
> > We could probably be a bit more specific about the situation, since the
> > user will see this message with no context. Maybe something like:
> >
> > unable to stat just-written file %s
> >
> > or something. We should probably a
Jeff King writes:
>> diff --git a/entry.c b/entry.c
>> index 5dab656364..2252d96756 100644
>> --- a/entry.c
>> +++ b/entry.c
>> @@ -355,7 +355,8 @@ static int write_entry(struct cache_entry *ce,
>> if (state->refresh_cache) {
>> assert(state->istate);
>> if (!fstat_
On Thu, Oct 05, 2017 at 12:44:07PM +0200, lars.schnei...@autodesk.com wrote:
> From: Lars Schneider
>
> If we are checking out a file and somebody else racily deletes our file,
> then we would write garbage to the cache entry. Fix that by checking
> the result of the lstat() call on that file. P
7 matches
Mail list logo
