Re: [PATCH 8/8] remote-curl: in v2, fill credentials if needed

On Mon, Feb 11, 2019 at 11:20:54AM -0800, Jonathan Tan wrote: > > In the case of proxy_request(), we don't know ahead of time whether the > > request is large or not; we just proxy the data through. And we don't do > > the probe thing at all. So wouldn't we dropping some data for the > > follow-up

Re: [PATCH 8/8] remote-curl: in v2, fill credentials if needed

> On Tue, Feb 05, 2019 at 04:21:22PM -0800, Jonathan Tan wrote: > > > In post_rpc(), remote-curl calls credential_fill() if HTTP_REAUTH is > > returned, but this is not true in proxy_request(). Do this in > > proxy_request() too. > > Can we do this as a general rule? If we look at the code in pos

Re: [PATCH 8/8] remote-curl: in v2, fill credentials if needed

On Tue, Feb 05, 2019 at 04:21:22PM -0800, Jonathan Tan wrote: > In post_rpc(), remote-curl calls credential_fill() if HTTP_REAUTH is > returned, but this is not true in proxy_request(). Do this in > proxy_request() too. Can we do this as a general rule? If we look at the code in post_rpc(), there