Re: [PATCH 7/7] config: flip return value of store_write_*()

On Wed, Sep 13, 2017 at 02:25:28PM -0700, Jonathan Nieder wrote: > > Let's flip them to follow the usual write() conventions and > > update all callers. As these are local to config.c, it's > > unlikely that we'd have new callers in any topics in flight > > (which would be silently broken by our c

Re: [PATCH 7/7] config: flip return value of store_write_*()

Hi, Jeff King wrote: > The store_write_section() and store_write_pairs() functions > are basically high-level wrappers around write(). But their > return values are flipped from our usual convention, using > "1" for success and "0" for failure. > > Let's flip them to follow the usual write() conv