Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats

2018-07-10 Thread Jeff King
On Tue, Jul 10, 2018 at 08:58:32AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Fri, Jul 06, 2018 at 10:24:58AM -0700, Junio C Hamano wrote: > > > >> What we've been avoiding was the comma after the last element in the > >> enum (in other words, if PGP_FMT had ',' after it in the ab

Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats

2018-07-10 Thread Junio C Hamano
Jeff King writes: > On Fri, Jul 06, 2018 at 10:24:58AM -0700, Junio C Hamano wrote: > >> What we've been avoiding was the comma after the last element in the >> enum (in other words, if PGP_FMT had ',' after it in the above >> quoted addition, that would have been violation of that rule), as >> h

Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats

2018-07-10 Thread Junio C Hamano
Jeff King writes: > On Fri, Jul 06, 2018 at 10:24:58AM -0700, Junio C Hamano wrote: > >> What we've been avoiding was the comma after the last element in the >> enum (in other words, if PGP_FMT had ',' after it in the above >> quoted addition, that would have been violation of that rule), as >> h

Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats

2018-07-10 Thread Jeff King
On Fri, Jul 06, 2018 at 10:24:58AM -0700, Junio C Hamano wrote: > What we've been avoiding was the comma after the last element in the > enum (in other words, if PGP_FMT had ',' after it in the above > quoted addition, that would have been violation of that rule), as > having such a trailing comma

Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats

2018-07-09 Thread Junio C Hamano
Eric Sunshine writes: > On Mon, Jul 9, 2018 at 4:22 AM Henning Schild > wrote: >> Am Fri, 6 Jul 2018 10:24:58 -0700 >> schrieb Junio C Hamano : >> > Martin Ågren writes: >> > >> +struct gpg_format_data gpg_formats[] = { >> > >> + { .format = "PGP", .program = "gpg", >> > >> + .ext

Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats

2018-07-09 Thread Eric Sunshine
On Mon, Jul 9, 2018 at 4:22 AM Henning Schild wrote: > Am Fri, 6 Jul 2018 10:24:58 -0700 > schrieb Junio C Hamano : > > Martin Ågren writes: > > >> +struct gpg_format_data gpg_formats[] = { > > >> + { .format = "PGP", .program = "gpg", > > >> + .extra_args_verify = { "--keyid-format

Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats

2018-07-09 Thread Henning Schild
Am Fri, 6 Jul 2018 10:24:58 -0700 schrieb Junio C Hamano : > Martin Ågren writes: > > >> +enum gpgformats { PGP_FMT }; > >> +struct gpg_format_data gpg_formats[] = { > >> + { .format = "PGP", .program = "gpg", > >> + .extra_args_verify = { "--keyid-format=long", }, > >> + .

Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats

2018-07-06 Thread Junio C Hamano
Martin Ågren writes: >> +enum gpgformats { PGP_FMT }; >> +struct gpg_format_data gpg_formats[] = { >> + { .format = "PGP", .program = "gpg", >> + .extra_args_verify = { "--keyid-format=long", }, >> + .sigs = { PGP_SIGNATURE, PGP_MESSAGE, }, >> + }, >> +}; > > I think t

Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats

2018-07-05 Thread Henning Schild
Am Wed, 4 Jul 2018 09:10:17 +0200 schrieb Martin Ågren : > Hi Henning, > > On 3 July 2018 at 14:38, Henning Schild > wrote: > > Create a struct that holds the format details for the supported > > formats. At the moment that is still just "PGP". This commit > > prepares for the introduction of mo

Re: [PATCH 4/8] gpg-interface: introduce an abstraction for multiple gpg formats

2018-07-04 Thread Martin Ågren
Hi Henning, On 3 July 2018 at 14:38, Henning Schild wrote: > Create a struct that holds the format details for the supported formats. > At the moment that is still just "PGP". This commit prepares for the > introduction of more formats, that might use other programs and match > other signatures.