Re: [PATCH 4/6] commit: use generations in paint_down_to_common()

2018-04-03 Thread Jonathan Tan
On Tue, 3 Apr 2018 12:51:41 -0400 Derrick Stolee wrote: > +int compare_commits_by_gen_then_commit_date(const void *a_, const void *b_, > void *unused) > +{ > + const struct commit *a = a_, *b = b_; > + > + if (a->generation < b->generation) > + return 1; > + else if (a->

Re: [PATCH 4/6] commit: use generations in paint_down_to_common()

2018-04-03 Thread Stefan Beller
On Tue, Apr 3, 2018 at 9:51 AM, Derrick Stolee wrote: > Define compare_commits_by_gen_then_commit_date(), which uses generation > numbers as a primary comparison and commit date to break ties (or as a > comparison when both commits do not have computed generation numbers). > > Since the commit-gra