Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-19 Thread Duy Nguyen
On Wed, Mar 19, 2014 at 9:14 PM, Stefan Beller wrote: > Maybe we should introduce another option --pack-for-archive > which features the characteristics of the old --aggressive. > And the new --aggressive would be a tradeoff between space and > time? > Thinking further we could add a couple of opt

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-19 Thread Duy Nguyen
On Tue, Mar 18, 2014 at 12:00 PM, Duy Nguyen wrote: >>> size time >>> old aggr. 36MB 5m51 >>> new aggr. 37MB 6m13 >>> repack -adf 48MB 1m12 >> >> I am not clear on what these times mean. It looks like the new code is >> slower _and_ bigger. Can you explain them? > > That's righ

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-18 Thread David Kastrup
Duy Nguyen writes: > On Tue, Mar 18, 2014 at 12:16 PM, Duy Nguyen wrote: >> But I think it's orthogonal to gc --aggressive improvement. > > There's another reason that improving gc may be a good idea (or not). > It depends on how other git implementations handle long delta chains. "Other git im

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread David Kastrup
Jeff King writes: > On Tue, Mar 18, 2014 at 12:50:50AM -0400, Jeff King wrote: > >> On Sun, Mar 16, 2014 at 08:35:04PM +0700, Nguyễn Thái Ngọc Duy wrote: >> >> > As explained in the previous commit, current aggressive settings >> > --depth=250 --window=250 could slow down repository access >> >

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread Duy Nguyen
On Tue, Mar 18, 2014 at 12:16 PM, Duy Nguyen wrote: > But I think it's orthogonal to gc --aggressive improvement. There's another reason that improving gc may be a good idea (or not). It depends on how other git implementations handle long delta chains. If they hate long delta chains like current

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread David Kastrup
Jeff King writes: > On Tue, Mar 18, 2014 at 12:00:48PM +0700, Duy Nguyen wrote: > >> On Tue, Mar 18, 2014 at 11:50 AM, Jeff King wrote: >> > On Sun, Mar 16, 2014 at 08:35:04PM +0700, Nguyễn Thái Ngọc Duy wrote: >> > >> >> As explained in the previous commit, current aggressive settings >> >> --d

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread Duy Nguyen
On Tue, Mar 18, 2014 at 12:07 PM, Jeff King wrote: > [before] > real0m28.824s > user0m28.620s > sys 0m0.232s > > [after] > real0m21.694s > user0m21.544s > sys 0m0.172s > > The numbers below are completely pulled out of a hat, so we can perhaps > do even bett

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread Jeff King
On Tue, Mar 18, 2014 at 12:00:48PM +0700, Duy Nguyen wrote: > On Tue, Mar 18, 2014 at 11:50 AM, Jeff King wrote: > > On Sun, Mar 16, 2014 at 08:35:04PM +0700, Nguyễn Thái Ngọc Duy wrote: > > > >> As explained in the previous commit, current aggressive settings > >> --depth=250 --window=250 could

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread Jeff King
On Tue, Mar 18, 2014 at 12:50:50AM -0400, Jeff King wrote: > On Sun, Mar 16, 2014 at 08:35:04PM +0700, Nguyễn Thái Ngọc Duy wrote: > > > As explained in the previous commit, current aggressive settings > > --depth=250 --window=250 could slow down repository access > > significantly. Notice that p

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread Duy Nguyen
On Tue, Mar 18, 2014 at 11:50 AM, Jeff King wrote: > On Sun, Mar 16, 2014 at 08:35:04PM +0700, Nguyễn Thái Ngọc Duy wrote: > >> As explained in the previous commit, current aggressive settings >> --depth=250 --window=250 could slow down repository access >> significantly. Notice that people usuall

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread Jeff King
On Sun, Mar 16, 2014 at 08:35:04PM +0700, Nguyễn Thái Ngọc Duy wrote: > As explained in the previous commit, current aggressive settings > --depth=250 --window=250 could slow down repository access > significantly. Notice that people usually work on recent history only, > we could keep recent hist

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread Junio C Hamano
Duy Nguyen writes: > On Tue, Mar 18, 2014 at 5:12 AM, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> As explained in the previous commit,... >> >> [PATCH 3/4] becomes a commit with an empty log message for some >> reason. Have you tried running "am -s" on it? > > "am -s" worked

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread Duy Nguyen
On Tue, Mar 18, 2014 at 5:12 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> As explained in the previous commit,... > > [PATCH 3/4] becomes a commit with an empty log message for some > reason. Have you tried running "am -s" on it? "am -s" worked fine. "am -s --scissors" did not

Re: [PATCH 4/4] gc --aggressive: three phase repacking

2014-03-17 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > As explained in the previous commit,... [PATCH 3/4] becomes a commit with an empty log message for some reason. Have you tried running "am -s" on it? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kern