Re: [PATCH 4/3] pack-bitmap.h: fix unused variable warning

2019-09-24 Thread Jeff King
On Tue, Sep 24, 2019 at 05:34:08PM -0400, Jeff King wrote: > > I'm tacking this patch on since this warning didn't show up until I > > compiled it on gcc 9.1.0. > > Curiously, I _don't_ see the warning with gcc 9.2.1. By my reading of > the manpage, this should be triggered by -Wunused-const-vari

Re: [PATCH 4/3] pack-bitmap.h: fix unused variable warning

2019-09-24 Thread Jeff King
On Tue, Sep 24, 2019 at 02:08:53AM -0700, Denton Liu wrote: > When we ran `make hdr-check`, we got the following warning on Arch Linux: > > pack-bitmap.h:20:19: error: ‘BITMAP_IDX_SIGNATURE’ defined but not used > [-Werror=unused-const-variable=] > 20 | static const char BITMAP_ID