Re: [PATCH 3/7] diff.c: do not pass diff options as keydata to hashmap

2018-04-06 Thread Stefan Beller
Hi Jeff, On Fri, Apr 6, 2018 at 1:04 PM, Jeff King wrote: > On Mon, Apr 02, 2018 at 03:48:50PM -0700, Stefan Beller wrote: > >> The diff options are passed to the compare function as >> 'hashmap_cmp_fn_data', which are given when the hashmaps >> are initialized. >> >> A later patch will make use

Re: [PATCH 3/7] diff.c: do not pass diff options as keydata to hashmap

2018-04-06 Thread Jeff King
On Mon, Apr 02, 2018 at 03:48:50PM -0700, Stefan Beller wrote: > The diff options are passed to the compare function as > 'hashmap_cmp_fn_data', which are given when the hashmaps > are initialized. > > A later patch will make use of the keydata to signal > different settings for comparision. I h