Re: [PATCH 3/5] grep: fix bug when recuring with relative pathspec

2017-03-02 Thread Brandon Williams
On 02/28, Junio C Hamano wrote: > Brandon Williams writes: > > > /* Add super prefix */ > > + quote_path_relative(name, opt->prefix, &buf); > > Hmph, do you want a quoted version here, not just relative_path()? > > Perhaps add a test with an "unusual" byte (e.g. a double-quote) in > the p

Re: [PATCH 3/5] grep: fix bug when recuring with relative pathspec

2017-02-28 Thread Junio C Hamano
Brandon Williams writes: > /* Add super prefix */ > + quote_path_relative(name, opt->prefix, &buf); Hmph, do you want a quoted version here, not just relative_path()? Perhaps add a test with an "unusual" byte (e.g. a double-quote) in the path? > argv_array_pushf(&cp.args, "--su