Re: [PATCH 3/4] range-diff: make use of different output indicators

2018-08-13 Thread Stefan Beller
> > strbuf_addbuf(&buf, &line); > > + } > > My preliminary reading (I sadly lack the time to pull your branch and play > with it) suggests that this works, although I have to admit that X/Y/Z > would confuse me in 6 months from now, as they do not really read like

Re: [PATCH 3/4] range-diff: make use of different output indicators

2018-08-13 Thread Johannes Schindelin
Hi Stefan, On Fri, 10 Aug 2018, Stefan Beller wrote: > This change itself only changes the internal communication and should > have no visible effect to the user. We instruct the diff code that produces > the inner diffs to use X, Y, Z instead of the usual markers for new, old > and context lines