Re: [PATCH 2/4] trailer: avoid unnecessary splitting on lines

2016-10-31 Thread Junio C Hamano
Christian Couder writes: > On Sat, Oct 29, 2016 at 2:05 AM, Jonathan Tan > wrote: >> trailer.c currently splits lines while processing a buffer (and also >> rejoins lines when needing to invoke ignore_non_trailer). >> >> Avoid such line splitting, except when generating the strings >> correspon

Re: [PATCH 2/4] trailer: avoid unnecessary splitting on lines

2016-10-31 Thread Junio C Hamano
Jonathan Tan writes: > diff --git a/trailer.c b/trailer.c > index 6d8375b..d4d9e10 100644 > --- a/trailer.c > +++ b/trailer.c > @@ -102,12 +102,12 @@ static int same_trailer(struct trailer_item *a, struct > arg_item *b) > return same_token(a, b) && same_value(a, b); > } > > -static inli

Re: [PATCH 2/4] trailer: avoid unnecessary splitting on lines

2016-10-29 Thread Christian Couder
On Sat, Oct 29, 2016 at 2:05 AM, Jonathan Tan wrote: > trailer.c currently splits lines while processing a buffer (and also > rejoins lines when needing to invoke ignore_non_trailer). > > Avoid such line splitting, except when generating the strings > corresponding to trailers (for ease of use by