Re: [PATCH 2/2] sideband: highlight keywords in remote sideband output

2018-08-06 Thread Junio C Hamano
Han-Wen Nienhuys writes: >> If your "make test" did not catch this as an error, then we may need >> to fix t/Makefile, as it is supposed to run test-lint. > > I've been running tests individually as > > sh t5409-colorize-remote-messages.sh -v -d During your own development that may be sufficie

Re: [PATCH 2/2] sideband: highlight keywords in remote sideband output

2018-08-06 Thread Han-Wen Nienhuys
On Fri, Aug 3, 2018 at 5:52 AM Jonathan Nieder wrote: > > Hi, > > Han-Wen Nienhuys wrote: > > > The colorization is controlled with the config setting "color.remote". > > > > Supported keywords are "error", "warning", "hint" and "success". They > > are highlighted if they appear at the start of th

Re: [PATCH 2/2] sideband: highlight keywords in remote sideband output

2018-08-06 Thread Han-Wen Nienhuys
On Thu, Aug 2, 2018 at 8:22 PM Junio C Hamano wrote: > > > > Helped-by: Duy Nguyen > > Signed-off-by: Han-Wen Nienhuys > > --- > > Documentation/config.txt| 9 +++ > > help.c | 1 + > > help.h | 1 + > > sideband.c

Re: [PATCH 2/2] sideband: highlight keywords in remote sideband output

2018-08-02 Thread Jonathan Nieder
Hi, Han-Wen Nienhuys wrote: > The colorization is controlled with the config setting "color.remote". > > Supported keywords are "error", "warning", "hint" and "success". They > are highlighted if they appear at the start of the line, which is > common in error messages, eg. > >ERROR: commit i

Re: [PATCH 2/2] sideband: highlight keywords in remote sideband output

2018-08-02 Thread Eric Sunshine
On Thu, Aug 2, 2018 at 8:13 AM Han-Wen Nienhuys wrote: > [PATCH 2/2] sideband: highlight keywords in remote sideband output The -v option of git-format-patch makes it easy to let reviewers know that this is a new version of a previously-submitted patch series. This (I think) is the second attempt

Re: [PATCH 2/2] sideband: highlight keywords in remote sideband output

2018-08-02 Thread Junio C Hamano
Han-Wen Nienhuys writes: > The colorization is controlled with the config setting "color.remote". > ... > Finally, this solution is backwards compatible: many servers already > prefix their messages with "error", and they will benefit from this > change without requiring a server update. By contr