Re: [PATCH 2/1] support -4 and -6 switches for remote operations

2016-01-31 Thread Torsten Bögershausen
On 2016-01-31 01.01, Eric Wong wrote: > Torsten Bögershausen wrote: >> On 2016-01-30 14.13, Eric Wong wrote: >>> The ssh(1) command has an equivalent switches which we may >>> pass when we run them. > >> Should we mention that putty and tortoiseplink don't have these options ? >> At least in the

Re: [PATCH 2/1] support -4 and -6 switches for remote operations

2016-01-30 Thread Jeff King
On Sun, Jan 31, 2016 at 12:01:44AM +, Eric Wong wrote: > > > --- a/builtin/clone.c > > > +++ b/builtin/clone.c > > > @@ -47,6 +47,7 @@ static const char *real_git_dir; > > > static char *option_upload_pack = "git-upload-pack"; > > > static int option_verbosity; > > > static int option_progr

Re: [PATCH 2/1] support -4 and -6 switches for remote operations

2016-01-30 Thread Eric Wong
Torsten Bögershausen wrote: > On 2016-01-30 14.13, Eric Wong wrote: > > The ssh(1) command has an equivalent switches which we may > > pass when we run them. > Should we mention that putty and tortoiseplink don't have these options ? > At least in the commit message ? Sure, will remember for v2

Re: [PATCH 2/1] support -4 and -6 switches for remote operations

2016-01-30 Thread Torsten Bögershausen
On 2016-01-30 14.13, Eric Wong wrote: Nicely done, some minor questions inline. > Sometimes, it is necessary to force IPv4-only or IPv6-only > operation on networks where name lookups may return a > non-routable address and stall remote operations. > > The ssh(1) command has an equivalent switches

Re: [PATCH 2/1] support -4 and -6 switches for remote operations

2016-01-30 Thread Eric Wong
Eric Wong wrote: > rsync support is untouched for now since it is deprecated > and scheduled to be removed. I forgot add I'm not sure how to actually go about testing these changes automatically since they involve DNS setups. And the test suite seems really slow nowadays, I guess/hope our test c