Re: [PATCH 19/24] refs.c: allow listing and deleting badly named refs

2014-10-03 Thread Junio C Hamano
Ronnie Sahlberg writes: > On Thu, Oct 2, 2014 at 11:55 AM, Junio C Hamano wrote: > ... >> Thanks. We originally threw all the different kind of breakages >> into ISBROKEN, but a ref can have a malformed name or can contain a >> bad/non value and allowing us to tell them apart is a good directio

Re: [PATCH 19/24] refs.c: allow listing and deleting badly named refs

2014-10-03 Thread Ronnie Sahlberg
On Fri, Oct 3, 2014 at 1:25 PM, Ronnie Sahlberg wrote: > On Thu, Oct 2, 2014 at 11:55 AM, Junio C Hamano wrote: >> Jonathan Nieder writes: >> >>> From: Ronnie Sahlberg >>> ... >>> In resolving functions, refuse to resolve refs that don't pass the >>> check-ref-format(1) check unless the new RES

Re: [PATCH 19/24] refs.c: allow listing and deleting badly named refs

2014-10-03 Thread Ronnie Sahlberg
On Thu, Oct 2, 2014 at 11:55 AM, Junio C Hamano wrote: > Jonathan Nieder writes: > >> From: Ronnie Sahlberg >> ... >> In resolving functions, refuse to resolve refs that don't pass the >> check-ref-format(1) check unless the new RESOLVE_REF_ALLOW_BAD_NAME >> flag is passed. Even with RESOLVE_RE

Re: [PATCH 19/24] refs.c: allow listing and deleting badly named refs

2014-10-02 Thread Junio C Hamano
Jonathan Nieder writes: > From: Ronnie Sahlberg > ... > In resolving functions, refuse to resolve refs that don't pass the > check-ref-format(1) check unless the new RESOLVE_REF_ALLOW_BAD_NAME > flag is passed. Even with RESOLVE_REF_ALLOW_BAD_NAME, refuse to > resolve refs that escape the refs/