Re: [PATCH 14/22] lockfile: use strbufs when handling (most) paths

2014-04-02 Thread Junio C Hamano
Michael Haggerty writes: > Change struct lock_file's filename field from a fixed-length buffer > into a strbuf. Good. As I allued to in a review on an unrelated patch, I do not think it is a good idea to name the lock filename field "lock_filename" in a structure that is about a lockfile, thoug

Re: [PATCH 14/22] lockfile: use strbufs when handling (most) paths

2014-04-01 Thread Jeff King
On Tue, Apr 01, 2014 at 05:58:22PM +0200, Michael Haggerty wrote: > /* > - * p = path that may be a symlink > - * s = full size of p > - * > - * If p is a symlink, attempt to overwrite p with a path to the real > - * file or directory (which may or may not exist), following a chain of > - * symli