Re: [PATCH 11/11] graph: fix coloring of octopus dashes

2019-10-13 Thread Jeff King
On Thu, Oct 10, 2019 at 11:16:24AM -0700, Denton Liu wrote: > > test_expect_success 'log --graph with normal octopus merge, no color' ' > > So, I decided to merge 'dl/octopus-graph-bug' with your branch and I > couldn't be happier! I had to make a couple of minor tweaks to the > existing test ca

Re: [PATCH 11/11] graph: fix coloring of octopus dashes

2019-10-10 Thread Denton Liu
On Thu, Oct 10, 2019 at 11:16:24AM -0700, Denton Liu wrote: > You can see the results of this by doing: > > $ git fetch https://github.com/Denton-L/git.git testing/graph-output > $ git diff FETCH_HEAD^2 t/t4214-log-graph-octopus.sh > > and the resulting diff is very pleasing imo. I g

Re: [PATCH 11/11] graph: fix coloring of octopus dashes

2019-10-10 Thread Denton Liu
Hi James, Nicely done! This issue was bugging me for a while! On Thu, Oct 10, 2019 at 09:13:52AM -0700, James Coglan via GitGitGadget wrote: [...] > diff --git a/t/t4214-log-graph-octopus.sh b/t/t4214-log-graph-octopus.sh > index 9ada687628..fbd485d83a 100755 > --- a/t/t4214-log-graph-octopus.s