Jonathan Nieder writes:
>> Which means the defaulting of git_connect::conn to &no_fork is now
>> unneeded. One of the things that made the original cascade a bit
>> harder to follow than necessary, aside from the physical length of
>> the PROTO_GIT part, was that the case where conn remains to p
Hi,
On Oct 24, 2017, Junio C Hamano wrote:
> Jonathan Nieder writes:
>> +static struct child_process *git_connect_git(int fd[2], char *hostandport,
>> + const char *path, const char *prog,
>> + int flags)
>> +{
>> +
On Mon, Oct 23, 2017 at 6:54 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> I think once this option is given, all we have to do is pay attention to
>> this option in diff.c#moved_entry_cmp/next_byte, which is best built
>> on top of Peffs recent fixes origin/jk/diff-color-moved-fix.
>> W
Stefan Beller writes:
> I think once this option is given, all we have to do is pay attention to
> this option in diff.c#moved_entry_cmp/next_byte, which is best built
> on top of Peffs recent fixes origin/jk/diff-color-moved-fix.
> Would that be of interest for people?
Two things and a half.
Jonathan Nieder writes:
> The git_connect function is growing long. Split the
> PROTO_GIT-specific portion to a separate function to make it easier to
> read.
>
> No functional change intended.
>
> Signed-off-by: Jonathan Nieder
> Reviewed-by: Stefan Beller
> ---
> As before, except with sbell
On Mon, Oct 23, 2017 at 2:29 PM, Jonathan Nieder wrote:
> The git_connect function is growing long. Split the
> PROTO_GIT-specific portion to a separate function to make it easier to
> read.
>
> No functional change intended.
>
> Signed-off-by: Jonathan Nieder
This also looks good to me.
unrel
6 matches
Mail list logo
