Jeff King writes:
> I had the same concern, but actually truncation is not a problem here
> (for a symlink or a symref). We are only seeing if the contents look
> vaguely correct, so really we never parse past "refs/" in either case.
Ahh, OK.
It seems that at least for this week, my reviews alw
On Wed, Sep 27, 2017 at 04:06:22PM +0900, Junio C Hamano wrote:
> A few tangents I noticed:
>
> - the result of readlink should be checked with starts_with() in
>the modern codebase (#leftoverbits).
Yes, though it needs to NUL-terminate, too (readlink does not do so
automatically). Again, w
Jeff King writes:
> diff --git a/path.c b/path.c
> index b533ec938d..3e4d7505ef 100644
> --- a/path.c
> +++ b/path.c
> @@ -662,6 +662,10 @@ int validate_headref(const char *path)
> len = read_in_full(fd, buffer, sizeof(buffer)-1);
> close(fd);
>
> + if (len < 0)
> +
3 matches
Mail list logo
