Re: [PATCH 1/3] Contextually notify user about an initial commit

On Tue, 2017-06-20 at 16:41 +0200, Ævar Arnfjörð Bjarmason wrote: > Right now 1/3 breaks the test suite. That's a big no-no, any given > commit should not break the test suite to not break bisecting. > > But aside from that the general pattern we follow is that if code > behavior changes, tests fo

Re: [PATCH 1/3] Contextually notify user about an initial commit

On Tue, Jun 20 2017, Kaartic Sivaraam jotted: > Thanks for trying to help. A few comments regarding your suggestions. > >> * Let's do that spacing fix (unrelated fix) in its own commit. >> > Ok. That's a good point. > >> * You should add tests along with the code being changed, and >> especially

Re: [PATCH 1/3] Contextually notify user about an initial commit

Thanks for trying to help. A few comments regarding your suggestions. >  * Let's do that spacing fix (unrelated fix) in its own commit. > Ok. That's a good point. >   * You should add tests along with the code being changed, and > especially change tests that would fail with your new code, >

Re: [PATCH 1/3] Contextually notify user about an initial commit

On Tue, Jun 20 2017, Kaartic Sivaraam jotted: > "git status" indicated "Initial commit" when HEAD points at > an unborn branch. This message is shared with the commit > log template "git commit" prepares for the user when > creating a commit (i.e. "You are about to create the initial > commit"),