Re: [PATCH 1/2 jk/war-on-sprintf] read_branches_file: plug a FILE* leak

2015-10-23 Thread Junio C Hamano
Johannes Sixt writes: > The earlier rewrite f28e3ab2 (read_branches_file: simplify string handling) > of read_branches_file() lost an fclose() call. Put it back. > > As on Windows files that are open cannot be removed, the leak manifests in > a failure of 'git remote rename origin origin' when th

Re: [PATCH 1/2 jk/war-on-sprintf] read_branches_file: plug a FILE* leak

2015-10-23 Thread Jeff King
On Fri, Oct 23, 2015 at 08:02:51AM +0200, Johannes Sixt wrote: > The earlier rewrite f28e3ab2 (read_branches_file: simplify string handling) > of read_branches_file() lost an fclose() call. Put it back. > > As on Windows files that are open cannot be removed, the leak manifests in > a failure of