Re: [PATCH 1/2] t0020-crlf: check the right file

2018-08-22 Thread Jeff King
On Wed, Aug 22, 2018 at 09:11:08AM -0700, Junio C Hamano wrote: > This originates from fd777141 ("t0020: fix ignored exit code inside > loops", 2015-03-25) where a loop > > for f in one dir/two > do > do things on "$f" || break > done > > was unrolled to correctly break o

Re: [PATCH 1/2] t0020-crlf: check the right file

2018-08-22 Thread Junio C Hamano
SZEDER Gábor writes: > In the test 'checkout with autocrlf=input' in 't0020-crlf.sh', one of > the 'has_cr' checks looks at the non-existing file 'two' instead of > 'dir/two'. The test still succeeds, without actually checking what it > was supposed to, because this check is expected to fail any