Re: [PATCH 1/2] run-command: factor out child_process_clear()

2015-10-27 Thread Stefan Beller
On Tue, Oct 27, 2015 at 2:29 PM, René Scharfe wrote: > Am 26.10.2015 um 20:23 schrieb Stefan Beller: >> >> On Mon, Oct 26, 2015 at 11:43 AM, Junio C Hamano >> wrote: >>> >>> René Scharfe writes: >>> Avoid duplication by moving the code to release allocated memory for arguments and envi

Re: [PATCH 1/2] run-command: factor out child_process_clear()

2015-10-27 Thread René Scharfe
Am 26.10.2015 um 20:23 schrieb Stefan Beller: On Mon, Oct 26, 2015 at 11:43 AM, Junio C Hamano wrote: René Scharfe writes: Avoid duplication by moving the code to release allocated memory for arguments and environment to its own function, child_process_clear(). Export it to provide a counter

Re: [PATCH 1/2] run-command: factor out child_process_clear()

2015-10-26 Thread Stefan Beller
On Mon, Oct 26, 2015 at 11:43 AM, Junio C Hamano wrote: > René Scharfe writes: > >> Avoid duplication by moving the code to release allocated memory for >> arguments and environment to its own function, child_process_clear(). >> Export it to provide a counterpart to child_process_init(). >> >> Si

Re: [PATCH 1/2] run-command: factor out child_process_clear()

2015-10-26 Thread Junio C Hamano
René Scharfe writes: > Avoid duplication by moving the code to release allocated memory for > arguments and environment to its own function, child_process_clear(). > Export it to provide a counterpart to child_process_init(). > > Signed-off-by: Rene Scharfe > --- Hmm, is this _deinit() Stefan a