Re: [PATCH 1/2] ident: check for useConfigOnly before auto-detection of name/email

2016-04-01 Thread Junio C Hamano
Marios Titas writes: > On Thu, Mar 31, 2016 at 10:40:03AM -0400, Jeff King wrote: >>On Wed, Mar 30, 2016 at 10:29:42PM +0300, Marios Titas wrote: >> >>> If user.useConfigOnly is set, it does not make sense to try to >>> auto-detect the name and/or the email. So it's better to do the >>> useConfig

Re: [PATCH 1/2] ident: check for useConfigOnly before auto-detection of name/email

2016-03-31 Thread Jeff King
On Thu, Mar 31, 2016 at 06:01:09PM +0300, Marios Titas wrote: > On Thu, Mar 31, 2016 at 10:40:03AM -0400, Jeff King wrote: > >On Wed, Mar 30, 2016 at 10:29:42PM +0300, Marios Titas wrote: > > > >>If user.useConfigOnly is set, it does not make sense to try to > >>auto-detect the name and/or the ema

Re: [PATCH 1/2] ident: check for useConfigOnly before auto-detection of name/email

2016-03-31 Thread Marios Titas
On Thu, Mar 31, 2016 at 10:40:03AM -0400, Jeff King wrote: On Wed, Mar 30, 2016 at 10:29:42PM +0300, Marios Titas wrote: If user.useConfigOnly is set, it does not make sense to try to auto-detect the name and/or the email. So it's better to do the useConfigOnly checks first. It might be nice

Re: [PATCH 1/2] ident: check for useConfigOnly before auto-detection of name/email

2016-03-31 Thread Jeff King
On Wed, Mar 30, 2016 at 10:29:42PM +0300, Marios Titas wrote: > If user.useConfigOnly is set, it does not make sense to try to > auto-detect the name and/or the email. So it's better to do the > useConfigOnly checks first. It might be nice to explain how it is better here. I'd guess it is because