Re: [PATCH 1/2] fsck_handle_reflog_sha1(): new function

2015-06-08 Thread Michael Haggerty
On 06/08/2015 05:07 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> New function, extracted from fsck_handle_reflog_ent(). The extra >> is_null_sha1() test for the new reference is currently unnecessary, as >> reflogs are deleted when the reference itself is deleted. But it >> doesn't h

Re: [PATCH 1/2] fsck_handle_reflog_sha1(): new function

2015-06-08 Thread Junio C Hamano
Michael Haggerty writes: > New function, extracted from fsck_handle_reflog_ent(). The extra > is_null_sha1() test for the new reference is currently unnecessary, as > reflogs are deleted when the reference itself is deleted. But it > doesn't hurt, either. I think we would crash with today's code

Re: [PATCH 1/2] fsck_handle_reflog_sha1(): new function

2015-06-08 Thread Johannes Schindelin
Hi Michael, On 2015-06-08 08:40, Michael Haggerty wrote: > New function, extracted from fsck_handle_reflog_ent(). The extra > is_null_sha1() test for the new reference is currently unnecessary, as > reflogs are deleted when the reference itself is deleted. But it > doesn't hurt, either. This patc