Re: [PATCH 1/2] fetch: avoid calling write_or_die()

On Mon, Mar 04, 2019 at 08:42:40PM +0700, Duy Nguyen wrote: > > - } else > > - write_or_die(fd, buf->buf, buf->len); > > + } else { > > + if (write_in_full(fd, buf->buf, buf->len) < 0) > > + die_errno("unable to write to remote"); > >

Re: [PATCH 1/2] fetch: avoid calling write_or_die()

On Sun, Mar 3, 2019 at 11:55 PM Jeff King wrote: > > The write_or_die() function has one quirk that a caller might not > expect: when it sees EPIPE from the write() call, it translates that > into a death by SIGPIPE. This doesn't change the overall behavior (the > program exits either way), but it