Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-14 Thread Jacob Keller
On Fri, Dec 14, 2018 at 9:47 AM Duy Nguyen wrote: > > On Fri, Dec 14, 2018 at 6:38 PM Duy Nguyen wrote: > > > > On Fri, Dec 14, 2018 at 6:22 PM Jacob Keller wrote: > > > > > > On Thu, Dec 13, 2018 at 11:38 PM Duy Nguyen wrote: > > > > Even with a new ref storage, I'm pretty sure pseudo refs lik

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-14 Thread Jacob Keller
On Fri, Dec 14, 2018 at 9:38 AM Duy Nguyen wrote: > > On Fri, Dec 14, 2018 at 6:22 PM Jacob Keller wrote: > > > > On Thu, Dec 13, 2018 at 11:38 PM Duy Nguyen wrote: > > > Even with a new ref storage, I'm pretty sure pseudo refs like HEAD, > > > FETCH_HEAD... will forever be backed by filesystem.

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-14 Thread Duy Nguyen
On Fri, Dec 14, 2018 at 6:38 PM Duy Nguyen wrote: > > On Fri, Dec 14, 2018 at 6:22 PM Jacob Keller wrote: > > > > On Thu, Dec 13, 2018 at 11:38 PM Duy Nguyen wrote: > > > Even with a new ref storage, I'm pretty sure pseudo refs like HEAD, > > > FETCH_HEAD... will forever be backed by filesystem.

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-14 Thread Duy Nguyen
On Fri, Dec 14, 2018 at 6:22 PM Jacob Keller wrote: > > On Thu, Dec 13, 2018 at 11:38 PM Duy Nguyen wrote: > > Even with a new ref storage, I'm pretty sure pseudo refs like HEAD, > > FETCH_HEAD... will forever be backed by filesystem. HEAD for example > > is part of the repository signature and m

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-14 Thread Jacob Keller
On Thu, Dec 13, 2018 at 11:38 PM Duy Nguyen wrote: > Even with a new ref storage, I'm pretty sure pseudo refs like HEAD, > FETCH_HEAD... will forever be backed by filesystem. HEAD for example > is part of the repository signature and must exist as a file. We could > also lookup pseudo refs with re

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-13 Thread Duy Nguyen
On Fri, Dec 14, 2018 at 7:50 AM Jacob Keller wrote: > > On Thu, Dec 13, 2018 at 1:16 PM Mike Rappazzo wrote: > > > > On Thu, Dec 13, 2018 at 3:48 PM Stefan Beller wrote: > > > > > > > > The current situation is definitely a problem. If I am in a worktree, > > > > > using "head" should be the sa

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-13 Thread Jacob Keller
On Thu, Dec 13, 2018 at 1:16 PM Mike Rappazzo wrote: > > On Thu, Dec 13, 2018 at 3:48 PM Stefan Beller wrote: > > > > > > The current situation is definitely a problem. If I am in a worktree, > > > > using "head" should be the same as "HEAD". > > > > By any chance, is your file system case insen

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-13 Thread Junio C Hamano
Duy Nguyen writes: > If you make "head" work like "HEAD", then it should work for _all_ > commands, not just worktree, and "MASTER" should match > "refs/heads/master" and so on. I don't think it's as simple as > changing strcmp to strcasecmp. You would need to make ref management > case-insensiti

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-13 Thread brian m. carlson
On Thu, Dec 13, 2018 at 04:14:28PM -0500, Mike Rappazzo wrote: > On Thu, Dec 13, 2018 at 3:48 PM Stefan Beller wrote: > > > > > > The current situation is definitely a problem. If I am in a worktree, > > > > using "head" should be the same as "HEAD". > > > > By any chance, is your file system cas

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-13 Thread Mike Rappazzo
On Thu, Dec 13, 2018 at 3:48 PM Stefan Beller wrote: > > > > The current situation is definitely a problem. If I am in a worktree, > > > using "head" should be the same as "HEAD". > > By any chance, is your file system case insensitive? > That is usually the source of confusion for these discussi

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-13 Thread Mike Rappazzo
On Thu, Dec 13, 2018 at 3:43 PM Duy Nguyen wrote: > > On Thu, Dec 13, 2018 at 9:34 PM Mike Rappazzo wrote: > > > > On Thu, Dec 13, 2018 at 3:23 PM Duy Nguyen wrote: > > > > > > On Thu, Dec 13, 2018 at 8:56 PM Michael Rappazzo via GitGitGadget > > > wrote: > > > > > > > > From: Michael Rappazzo

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-13 Thread Stefan Beller
> > The current situation is definitely a problem. If I am in a worktree, > > using "head" should be the same as "HEAD". By any chance, is your file system case insensitive? That is usually the source of confusion for these discussions. Maybe in worktree code we have a spillover between path res

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-13 Thread Duy Nguyen
On Thu, Dec 13, 2018 at 9:34 PM Mike Rappazzo wrote: > > On Thu, Dec 13, 2018 at 3:23 PM Duy Nguyen wrote: > > > > On Thu, Dec 13, 2018 at 8:56 PM Michael Rappazzo via GitGitGadget > > wrote: > > > > > > From: Michael Rappazzo > > > > > > On a worktree which is not the primary, using the symbol

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-13 Thread Mike Rappazzo
On Thu, Dec 13, 2018 at 3:23 PM Duy Nguyen wrote: > > On Thu, Dec 13, 2018 at 8:56 PM Michael Rappazzo via GitGitGadget > wrote: > > > > From: Michael Rappazzo > > > > On a worktree which is not the primary, using the symbolic-ref 'head' was > > incorrectly pointing to the main worktree's HEAD.

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

2018-12-13 Thread Duy Nguyen
On Thu, Dec 13, 2018 at 8:56 PM Michael Rappazzo via GitGitGadget wrote: > > From: Michael Rappazzo > > On a worktree which is not the primary, using the symbolic-ref 'head' was > incorrectly pointing to the main worktree's HEAD. The same was true for > any other case of the word 'Head'. > > Sig