Re: [PATCH 1/1] rebase -i: introduce the 'break' command

2018-10-08 Thread Junio C Hamano
Junio C Hamano writes: >> There is one crucial difference: the exit code. > > OK, and it was good that you explicitly said "with exit code 0" in > the log message. Together with the idea to update the doc I floated > earlier, this probably is worth documenting, too. Heh, I am becoming sloppy in

Re: [PATCH 1/1] rebase -i: introduce the 'break' command

2018-10-08 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Fri, 5 Oct 2018, Junio C Hamano wrote: > >> "Johannes Schindelin via GitGitGadget" >> writes: >> >> > From: Johannes Schindelin >> > >> > The 'edit' command can be used to cherry-pick a commit and then >> > immediately drop out of the interactive

Re: [PATCH 1/1] rebase -i: introduce the 'break' command

2018-10-05 Thread Johannes Schindelin
Hi Junio, On Fri, 5 Oct 2018, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > The 'edit' command can be used to cherry-pick a commit and then > > immediately drop out of the interactive rebase, with exit code 0, to let > > the us

Re: [PATCH 1/1] rebase -i: introduce the 'break' command

2018-10-05 Thread Jacob Keller
On Fri, Oct 5, 2018 at 1:17 AM Junio C Hamano wrote: > If one wants to emulate this with the versions of Git that are > currently deployed, would it be sufficient to insert "exec false" > instead of "break"? > > The reason I am asking is *not* to imply that we do not need this > new feature. It i

Re: [PATCH 1/1] rebase -i: introduce the 'break' command

2018-10-05 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > The 'edit' command can be used to cherry-pick a commit and then > immediately drop out of the interactive rebase, with exit code 0, to let > the user amend the commit, or test it, or look around. > > Sometimes this fu