Re: [PATCH 07/16] update submodules: introduce submodule_is_interesting

2016-11-17 Thread Stefan Beller
On Thu, Nov 17, 2016 at 2:57 AM, Heiko Voigt wrote: > It seems that you are only looking at the submodule config from a > commit. Should a user be able to override this with local configuration? > Haven't looked further in the patchseries so maybe that is somewhere > else? It turns out that in l

Re: [PATCH 07/16] update submodules: introduce submodule_is_interesting

2016-11-17 Thread Stefan Beller
On Tue, Nov 15, 2016 at 4:14 PM, David Turner wrote: >> +int submodule_is_interesting(const char *path, const unsigned char >> +*sha1) { > > This is apparently only ever (in this series) called with null_sha1. So > either this arg is unnecessary, or there are bugs elsewhere in the code. I was

RE: [PATCH 07/16] update submodules: introduce submodule_is_interesting

2016-11-15 Thread David Turner
> -Original Message- > From: Stefan Beller [mailto:sbel...@google.com] > Sent: Tuesday, November 15, 2016 6:07 PM > Cc: git@vger.kernel.org; bmw...@google.com; gits...@pobox.com; > jrnie...@gmail.com; mogulgu...@gmail.com; David Turner; Stefan Beller > Subject: [PATCH 07/16] update submodul

Re: [PATCH 07/16] update submodules: introduce submodule_is_interesting

2016-11-15 Thread Brandon Williams
On 11/15, Stefan Beller wrote: > +/** > + * When updating the working tree, do we need to check if the submodule needs > + * updating. We do not require a check if we are already sure that the > + * submodule doesn't need updating, e.g. when we are not interested in > submodules > + * or the submo