Re: [PATCH 05/18] branch-diff: also show the diff between patches

2018-05-04 Thread Johannes Schindelin
Hi Eric, On Thu, 3 May 2018, Eric Sunshine wrote: > On Thu, May 3, 2018 at 11:30 AM, Johannes Schindelin > wrote: > > Just like tbdiff, we now show the diff between matching patches. This is > > a "diff of two diffs", so it can be a bit daunting to read for the > > beginnger. > > s/beginnger/be

Re: [PATCH 05/18] branch-diff: also show the diff between patches

2018-05-03 Thread Eric Sunshine
On Thu, May 3, 2018 at 10:51 PM, Eric Sunshine wrote: > On Thu, May 3, 2018 at 11:30 AM, Johannes Schindelin > wrote: >> Note: while we now parse diff options such as --color, the effect is not >> yet the same as in tbdiff, where also the commit pairs would be colored. > > "... tbdiff, in which t

Re: [PATCH 05/18] branch-diff: also show the diff between patches

2018-05-03 Thread Eric Sunshine
On Thu, May 3, 2018 at 11:30 AM, Johannes Schindelin wrote: > Just like tbdiff, we now show the diff between matching patches. This is > a "diff of two diffs", so it can be a bit daunting to read for the > beginnger. s/beginnger/beginner/ > This brings branch-diff closer to be feature-complete w