Re: [PATCH 04/11] multi-pack-index: verify packname order

2018-09-05 Thread Derrick Stolee
On 9/5/2018 3:14 PM, Stefan Beller wrote: On Wed, Sep 5, 2018 at 12:11 PM Derrick Stolee wrote: On 9/5/2018 2:15 PM, Stefan Beller wrote: On Wed, Sep 5, 2018 at 7:46 AM Derrick Stolee via GitGitGadget wrote: From: Derrick Stolee The final check we make while loading a multi-pack-index is t

Re: [PATCH 04/11] multi-pack-index: verify packname order

2018-09-05 Thread Stefan Beller
On Wed, Sep 5, 2018 at 12:11 PM Derrick Stolee wrote: > > On 9/5/2018 2:15 PM, Stefan Beller wrote: > > On Wed, Sep 5, 2018 at 7:46 AM Derrick Stolee via GitGitGadget > > wrote: > >> From: Derrick Stolee > >> > >> The final check we make while loading a multi-pack-index is that > >> the packfile

Re: [PATCH 04/11] multi-pack-index: verify packname order

2018-09-05 Thread Derrick Stolee
On 9/5/2018 2:15 PM, Stefan Beller wrote: On Wed, Sep 5, 2018 at 7:46 AM Derrick Stolee via GitGitGadget wrote: From: Derrick Stolee The final check we make while loading a multi-pack-index is that the packfile names are in lexicographical order. Make this error be a die() instead. What is t

Re: [PATCH 04/11] multi-pack-index: verify packname order

2018-09-05 Thread Stefan Beller
On Wed, Sep 5, 2018 at 7:46 AM Derrick Stolee via GitGitGadget wrote: > > From: Derrick Stolee > > The final check we make while loading a multi-pack-index is that > the packfile names are in lexicographical order. Make this error > be a die() instead. What is the advantage of having a die() her