Re: [PATCH 02/15] apply.c: stop using index compat macros

2018-07-09 Thread Duy Nguyen
On Tue, Jul 3, 2018 at 8:30 PM Junio C Hamano wrote: > > Duy Nguyen writes: > > > A singe patch conversion would look like below. But for that to > > happen, convert.c, rerere, ws.c and read-cache.c have to be converted > > first to not use the_index. > > Yes, that was pretty much what I was driv

Re: [PATCH 02/15] apply.c: stop using index compat macros

2018-07-03 Thread Junio C Hamano
Duy Nguyen writes: > A singe patch conversion would look like below. But for that to > happen, convert.c, rerere, ws.c and read-cache.c have to be converted > first to not use the_index. Yes, that was pretty much what I was driving at. I do not have any trouble seeing a patch that converts call

Re: [PATCH 02/15] apply.c: stop using index compat macros

2018-06-30 Thread Duy Nguyen
On Mon, Jun 25, 2018 at 10:27:23AM -0700, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > > > Signed-off-by: Nguyễn Thái Ngọc Duy > > --- > > apply.c | 34 +++--- > > 1 file changed, 19 insertions(+), 15 deletions(-) > > Until all the codepaths that reach th

Re: [PATCH 02/15] apply.c: stop using index compat macros

2018-06-25 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > apply.c | 34 +++--- > 1 file changed, 19 insertions(+), 15 deletions(-) Until all the codepaths that reach these callsites to index_* functions from cmd_main() are converted to pass "struct