Re: [PATCH 02/14] trace2: create new combined trace facility

2019-01-25 Thread Junio C Hamano
SZEDER Gábor writes: >> +if (ctx->nr_open_regions > 0) { >> +int len_indent = TR2_INDENT_LENGTH(ctx); >> +while (len_indent > dots.len) { >> +strbuf_addf(buf, "%s", dots.buf); > > Please use the much simpler are more idiomatic strbuf_addbuf() > func

Re: [PATCH 02/14] trace2: create new combined trace facility

2019-01-25 Thread SZEDER Gábor
On Tue, Jan 22, 2019 at 01:22:14PM -0800, Jeff Hostetler via GitGitGadget wrote: > diff --git a/trace2/tr2_tgt_perf.c b/trace2/tr2_tgt_perf.c > new file mode 100644 > index 00..035855d883 > --- /dev/null > +++ b/trace2/tr2_tgt_perf.c > @@ -0,0 +1,573 @@ > +static struct strbuf dots = STRBU