Re: [PATCH 0/9] trailer-parsing false positives

2018-08-24 Thread Jeff King
On Thu, Aug 23, 2018 at 11:30:54AM -0700, Junio C Hamano wrote: > > Now here's the tricky part. I think patches 1-8 are mostly sensible. > > Yeah, nothing that made me go "Huh?" in these 8 patches. Thanks. > > > So I think there may be further opportunities for cleanup here. I'm not > > sure if

Re: [PATCH 0/9] trailer-parsing false positives

2018-08-23 Thread Junio C Hamano
Jeff King writes: > So this turned into a bit of a rabbit hole. Here's what I have so far > (which I think is not quite ready, but I wanted to start discussing). > > Issues (2) and (3) are actually the same issue. The caller that does the > bogus appending for (2) is always append_signoff(). But