Re: [PATCH 0/5] disallow test_when_finished in subshells

2015-09-05 Thread Junio C Hamano
>> Isn't it just the matter of resetting the variable regardless of $BASH >> (and ignoring >> a possible refusal to do so under bash) at the beginning of the test, or do >> you >> really have to rely on the value of $BASH and do things differently? > > Bash doesn't refuse to set it, it lets you up

Re: [PATCH 0/5] disallow test_when_finished in subshells

2015-09-05 Thread John Keeping
On Sat, Sep 05, 2015 at 10:36:29AM -0700, Junio C Hamano wrote: > On Sat, Sep 5, 2015 at 6:12 AM, John Keeping wrote: > > > > I don't think it's worth trying to clear $BASH_SUBSHELL before the tests > > start because to do so we have to reliably detect that we're not running > > under Bash, and if

Re: [PATCH 0/5] disallow test_when_finished in subshells

2015-09-05 Thread Junio C Hamano
On Sat, Sep 5, 2015 at 6:12 AM, John Keeping wrote: > > I don't think it's worth trying to clear $BASH_SUBSHELL before the tests > start because to do so we have to reliably detect that we're not running > under Bash, and if we don't trust people not to set $BASH_SUBSHELL why > do we trust them no