Re: [PATCH 0/2] negotiator: improve recent behavior + docs

2018-09-27 Thread Jonathan Tan
> I get: > > warning: Ignoring --negotiation-tip because the protocol does not support > it. When I implemented --negotiation-tip, I only implemented it for protocols that support connect or stateless-connect, because implementing it fully would have required expanding the protocol helper fu

Re: [PATCH 0/2] negotiator: improve recent behavior + docs

2018-09-27 Thread Ævar Arnfjörð Bjarmason
On Thu, Sep 27 2018, Jonathan Tan wrote: >> > If you wanted to do this, it seems better to me to just declare a "null" >> > negotiation algorithm that does not perform any negotiation at all. >> >> I think such an algorithm is a good idea in general, especially for >> testing, and yeah, maybe th

Re: [PATCH 0/2] negotiator: improve recent behavior + docs

2018-09-27 Thread Jonathan Tan
> > If you wanted to do this, it seems better to me to just declare a "null" > > negotiation algorithm that does not perform any negotiation at all. > > I think such an algorithm is a good idea in general, especially for > testing, and yeah, maybe that's the best way out of this, i.e. to do: > >

Re: [PATCH 0/2] negotiator: improve recent behavior + docs

2018-08-01 Thread Ævar Arnfjörð Bjarmason
On Wed, Aug 01 2018, Jonathan Tan wrote: >> I think 01/02 in this patch series implements something that's better >> & more future-proof. > > Thanks. Both patches are: > Reviewed-by: Jonathan Tan > > A small note: > >> -packfile; any other value instructs Git to use the default algorithm >>

Re: [PATCH 0/2] negotiator: improve recent behavior + docs

2018-08-01 Thread Jonathan Tan
> I think 01/02 in this patch series implements something that's better > & more future-proof. Thanks. Both patches are: Reviewed-by: Jonathan Tan A small note: > - packfile; any other value instructs Git to use the default algorithm > + packfile; The default is "default" which instruct