Re: [PATCH 0/2] fix spurious space after linkgit, now in *.html

2019-03-11 Thread Martin Ågren
On Mon, 11 Mar 2019 at 10:24, Junio C Hamano wrote: > > Martin Ågren writes: > > > Ok, then I'll take that offer. I'll squash these two patches into the > > original series. Thanks. > > Our mails might cross, but just in case you haven't started, here > are the locally squashed results with updat

Re: [PATCH 0/2] fix spurious space after linkgit, now in *.html

2019-03-11 Thread Junio C Hamano
Martin Ågren writes: > Ok, then I'll take that offer. I'll squash these two patches into the > original series. Thanks. Our mails might cross, but just in case you haven't started, here are the locally squashed results with updated log messages.

Re: [PATCH 0/2] fix spurious space after linkgit, now in *.html

2019-03-10 Thread Martin Ågren
On Mon, 11 Mar 2019 at 03:59, Jeff King wrote: > > On Sun, Mar 10, 2019 at 04:14:22PM +0100, Martin Ågren wrote: > > > [1] I could have sworn I checked the html docs and saw that they didn't > > have this extra space. Looking at git-scm.com again reveals that it's > > not there. Huh. Seems like th

Re: [PATCH 0/2] fix spurious space after linkgit, now in *.html

2019-03-10 Thread Martin Ågren
On Mon, 11 Mar 2019 at 04:02, Junio C Hamano wrote: > > Martin Ågren writes: > > > Since this has hit "next", here are two patches on top to address this. > > > > Sorry about this. > > Thanks. > > If it makes it easier, we can eject ma/asciidoctor-fixes out of > 'next' when we rebuild 'next'. I

Re: [PATCH 0/2] fix spurious space after linkgit, now in *.html

2019-03-10 Thread Junio C Hamano
Martin Ågren writes: > Bleh. For some reason [1] I thought the html-files were exempt from this > "extra space after linkgit" problem. They're not, as I just noticed. To > add insult to injury, my original patch 2 which adds a missing > dependency to the xml targets fails to add the exact same de

Re: [PATCH 0/2] fix spurious space after linkgit, now in *.html

2019-03-10 Thread Jeff King
On Sun, Mar 10, 2019 at 04:14:22PM +0100, Martin Ågren wrote: > [1] I could have sworn I checked the html docs and saw that they didn't > have this extra space. Looking at git-scm.com again reveals that it's > not there. Huh. Seems like the site's html-rendering doesn't go through our > Makefile a