Re: [PATCH 0/2] Fix a refname trimming problem in `log --bisect`

2017-06-14 Thread Junio C Hamano
Michael Haggerty writes: > The code for `git log --bisect` was calling > `for_each_ref_in_submodule()` with prefix set to "refs/bisect/bad", > which is the actual name of the reference that it wants. This resulted > in the refname being trimmed completely away and the empty string > being passed

Re: [PATCH 0/2] Fix a refname trimming problem in `log --bisect`

2017-06-14 Thread Jeff King
On Wed, Jun 14, 2017 at 11:07:25AM +0200, Michael Haggerty wrote: > Fix the problem in two orthogonal ways: > > 1. Add a new function, `for_each_fullref_in_submodule()`, that doesn't >trim the refnames that it passes to callbacks, and us that instead. >I *think* that this is a strict impr